misc: adapt codebuild ci for alternative repos #1589
Conversation
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
1 similar comment
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
0marperez
force-pushed
the
codebuild-ci-fix
branch
from
e9f96d7 to
1343e63
Compare
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
0marperez
added
the
acknowledge-artifact-size-increase
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
The |
| --source-version $SOURCE_VERSION \ | ||
| --environment-variables-override file:///tmp/gh_env_vars.json | ||
| --environment-variables-override file:///tmp/gh_env_vars.json \ | ||
| --source-type-override GITHUB \ |
There was a problem hiding this comment.
Isn't the source provider already GitHub, why do we have to override it to set GitHub again?
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
| --source-version $SOURCE_VERSION \ | ||
| --environment-variables-override file:///tmp/gh_env_vars.json | ||
| --environment-variables-override file:///tmp/gh_env_vars.json \ | ||
| --source-location-override https://github.com/awslabs/"$GITHUB_REPOSITORY_NO_ORG".git |
There was a problem hiding this comment.
Nit: The quotes should generally be around an entire argument, not just a substring. Example:
aws codebuild start-build-batch \
--project-name "$PROJECT_NAME" \
--source-version "$SOURCE_VERSION" \
--environment-variables-override file:///tmp/gh_env_vars.json \
--source-location-override "https://github.com/awslabs/$GITHUB_REPOSITORY_NO_ORG.git"
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
3 participants
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.