Skip to content

misc: adapt codebuild ci for alternative repos #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2025
Merged

misc: adapt codebuild ci for alternative repos #1589

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1343e63
misc: adapt codebuild ci for alternative repos
0marperez May 1, 2025
df8fa5e
ci run
0marperez May 2, 2025
3ff75b1
ci run
0marperez May 2, 2025
b22037f
test removing source-type-override
0marperez May 2, 2025
c8aea08
remove test
0marperez May 2, 2025
75071e7
fix argument quotes
0marperez May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/scripts/run-codebuild-batch-job.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ START_RESULT=$(
aws codebuild start-build-batch \
--project-name ${PROJECT_NAME} \
--source-version $SOURCE_VERSION \
--environment-variables-override file:///tmp/gh_env_vars.json
--environment-variables-override file:///tmp/gh_env_vars.json \
--source-type-override GITHUB \
Copy link
Member

@lauzadis lauzadis May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the source provider already GitHub, why do we have to override it to set GitHub again?

--source-location-override https://github.com/awslabs/"$GITHUB_REPOSITORY_NO_ORG".git
Copy link
Contributor

@ianbotsf ianbotsf May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The quotes should generally be around an entire argument, not just a substring. Example:

 aws codebuild start-build-batch \
    --project-name "$PROJECT_NAME" \
    --source-version "$SOURCE_VERSION" \
    --environment-variables-override file:///tmp/gh_env_vars.json \
    --source-location-override "https://github.com/awslabs/$GITHUB_REPOSITORY_NO_ORG.git"

)

if [ "$?" != "0" ]; then
Expand Down
Loading