telemetry: add "initialized" lsp stage #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LanguageServerSetupStage does not include initialized stage which is needed in VS and LSP protocol.
VS had an issue where needed to diagnose and measure customer failures that occur after the lsp was successfully started but the IDE failed to make a successful "initialized" communication.
For reference, LSP clients send an "initialize" message back and forth, and then they send an "initialized" message back and forth. The related pr is here.
Solution
I add the initialized stage in common's definition. The initialize stage is defined as handshake in common's definition so we do not need to make any modification for initialize.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.