Skip to content

telemetry(amazonq): add id2 metric #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

telemetry(amazonq): add id2 metric #1005

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65b1174
telemetry(amazonq): Add id2 and logging for createUpload metrics
zuoyaofu Mar 26, 2025
12819e9
add more details to the descriptions and id name
zuoyaofu Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,6 +1549,11 @@
"type": "string",
"description": "Metric-defined identifier"
},
{
"name": "id2",
Copy link
Contributor

@awschristou awschristou Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is too generic to be meaningful. "eg: Whats id2 is it more special than the id field?"

If it is s3 specific, would it make sense to name it s3_id2? Could it be generalized to something like responseHeader?

Copy link
Contributor Author

@zuoyaofu zuoyaofu Mar 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update! It is not specific to S3, but I guess I can also name it requestId2. Thanks for pointing that out.

"type": "string",
"description": "x-amz-id-2 for S3 Upload Debugging"
Copy link
Contributor

@awschristou awschristou Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its great to see an example, but please add a proper description to explain the field.

},
{
"name": "includesFix",
"type": "boolean",
Expand Down Expand Up @@ -2471,6 +2476,10 @@
"type": "duration",
"required": false
},
{
"type": "id2",
"required": false
},
{
"type": "reason",
"required": false
Expand Down