telemetry(amazonq): add id2 metric #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awschristou
reviewed
Mar 26, 2025
| "description": "Metric-defined identifier" | ||
| }, | ||
| { | ||
| "name": "id2", |
Contributor
There was a problem hiding this comment.
This name is too generic to be meaningful. "eg: Whats id2 is it more special than the id field?"
If it is s3 specific, would it make sense to name it s3_id2? Could it be generalized to something like responseHeader?
Contributor
Author
There was a problem hiding this comment.
Will update! It is not specific to S3, but I guess I can also name it requestId2. Thanks for pointing that out.
| { | ||
| "name": "id2", | ||
| "type": "string", | ||
| "description": "x-amz-id-2 for S3 Upload Debugging" |
Contributor
There was a problem hiding this comment.
Its great to see an example, but please add a proper description to explain the field.
awschristou
approved these changes
Mar 26, 2025
Contributor
awschristou
left a comment
awschristou
left a comment
There was a problem hiding this comment.
I'm approving the change to unblock some priority work. There's a good chance this new field will be revisited for a potential rename.
justinmk3
pushed a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Mar 27, 2025
## Problem Some users are reporting S3 upload failures but we don't have the id2 that S3 team requires to investigate further. Related Commons change: [#1005](aws/aws-toolkit-common#1005) ## Solution Emit amazonq_createUpload metric with id2, and add logs for these ids so customers can use too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Some users are reporting S3 upload failures but we don't have the id2 that S3 team requires to investigate further.
Emit amazonq_createUpload metric with id2, and add logs for these ids so customers can use too.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.