Skip to content

Add QCodeReviewTool Metric Definition #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2025
Merged

Add QCodeReviewTool Metric Definition #1065

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8cd5ea9
NEW: add QCodeReview tool metric definition
mkovelam Jul 16, 2025
05a287b
FIX: fixing amazonq_qCodeReviewTool metric description
mkovelam Jul 16, 2025
77d3cff
NEW: adding required metric definitions for Agentic review tool
mkovelam Jul 17, 2025
e47d240
FIX: removing not used metric definition
mkovelam Jul 17, 2025
9a44a11
FIX: updated metric definitions and fixed the sort order
mkovelam Jul 17, 2025
7121e4e
FIX: udpated codeReview Tools metric definitions
mkovelam Jul 18, 2025
5b97cf6
FIX: updating codeReviewTool metric definitions
mkovelam Jul 18, 2025
f96ba4a
FIX: fix for failed tests
mkovelam Jul 18, 2025
f797ea2
FIX: fixing alphabetical order
mkovelam Jul 18, 2025
1612e9c
FIX: fixing alphabetical order
mkovelam Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 54 additions & 3 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@
"type": "int",
"description": "Time taken to fetch the upload URL and upload the artifacts in milliseconds"
},
{
"name": "artifactType",
"type": "string",
"description": "type of artifact used in a request"
},
{
"name": "attempts",
"type": "int",
Expand Down Expand Up @@ -572,7 +577,7 @@
{
"name": "codewhispererCodeScanJobId",
"type": "string",
"description": "The ID of the security scan job"
"description": "The ID of the scan job"
},
{
"name": "codewhispererCodeScanLines",
Expand Down Expand Up @@ -603,12 +608,12 @@
{
"name": "codewhispererCodeScanSrcZipFileBytes",
"type": "int",
"description": "The compressed payload size of source files in bytes of customer project context sent for security scan"
"description": "The compressed payload size of source files in bytes of customer project context sent for scan"
},
{
"name": "codewhispererCodeScanTotalIssues",
"type": "int",
"description": "The number of security issues been detected"
"description": "The number of issues been detected"
},
{
"name": "codewhispererCompletionType",
Expand Down Expand Up @@ -993,6 +998,11 @@
"other"
]
},
{
"name": "customRules",
"type": "int",
"description": "number of custom rules present in a request"
},
{
"name": "cwsprAgenticChatInteractionType",
"type": "string",
Expand Down Expand Up @@ -2671,6 +2681,47 @@
}
]
},
{
"name": "amazonq_codeReviewTool",
"description": "This metric is used to evaluate Amazon Q's code review tool",
"metadata": [
{
"type": "artifactType",
"required": false
},
{
"type": "codewhispererCodeScanJobId",
"required": false
},
{
"type": "codewhispererCodeScanSrcZipFileBytes",
"required": false
},
{
"type": "codewhispererCodeScanTotalIssues",
"required": false
},
{
"type": "customRules",
"required": false
},
{
"type": "reason",
"required": false
},
{
"type": "reasonDesc",
"required": false
},
{
"type": "result"
},
{
"type": "scope",
Copy link
Contributor

@laileni-aws laileni-aws Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
This can be a required field!

Copy link
Contributor

@laileni-aws laileni-aws Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW Thanks for reusing this field!

"required": false
}
]
},
{
"name": "amazonq_createUpload",
"description": "Captures createUploadUrl invocation process",
Expand Down