Add QCodeReviewTool Metric Definition #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: Adding new amazonq_qCodeReviewTool metric definition How? added new definition
laileni-aws
reviewed
Jul 16, 2025
laileni-aws
requested changes
Jul 16, 2025
Contributor
laileni-aws
left a comment
laileni-aws
left a comment
There was a problem hiding this comment.
Tests are failing! Please check
abhraina-aws
approved these changes
Jul 17, 2025
laileni-aws
reviewed
Jul 17, 2025
laileni-aws
reviewed
Jul 18, 2025
| { | ||
| "name": "codewhispererCodeScanScope", | ||
| "type": "string", | ||
| "description": "The scope of the security scan being performed", |
Contributor
There was a problem hiding this comment.
Check if this is not used in existing code base if Yes then we should be good
laileni-aws
reviewed
Jul 18, 2025
BlakeLazarine
approved these changes
Jul 18, 2025
laileni-aws
reviewed
Jul 18, 2025
| "type": "result" | ||
| }, | ||
| { | ||
| "type": "scope", |
Contributor
There was a problem hiding this comment.
nit:
This can be a required field!
Contributor
There was a problem hiding this comment.
BTW Thanks for reusing this field!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently QCodeReviewTool do not have any metric name/definition defined to emit metrics
Solution
Added a new metric definition.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.