Skip to content

Add QCodeReviewTool Metric Definition #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2025
Merged

Add QCodeReviewTool Metric Definition #1065

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8cd5ea9
NEW: add QCodeReview tool metric definition
mkovelam Jul 16, 2025
05a287b
FIX: fixing amazonq_qCodeReviewTool metric description
mkovelam Jul 16, 2025
77d3cff
NEW: adding required metric definitions for Agentic review tool
mkovelam Jul 17, 2025
e47d240
FIX: removing not used metric definition
mkovelam Jul 17, 2025
9a44a11
FIX: updated metric definitions and fixed the sort order
mkovelam Jul 17, 2025
7121e4e
FIX: udpated codeReview Tools metric definitions
mkovelam Jul 18, 2025
5b97cf6
FIX: updating codeReviewTool metric definitions
mkovelam Jul 18, 2025
f96ba4a
FIX: fix for failed tests
mkovelam Jul 18, 2025
f797ea2
FIX: fixing alphabetical order
mkovelam Jul 18, 2025
1612e9c
FIX: fixing alphabetical order
mkovelam Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 168 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,48 @@
"applyFix"
]
},
{
"name": "codeReviewArtifactId",
"type": "string",
"description": "Unique identifier of the uploaded artifact for agentic review"
},
{
"name": "codeReviewArtifactSize",
"type": "double",
"description": "Size of the artifact reviewed/scanned in bytes"
},
{
"name": "codeReviewArtifactType",
"type": "string",
"description": "Type of the artifact requested for code review",
"allowedValues": ["FILE", "FOLDER"]
},
{
"name": "codeReviewCustomRulesCount",
"type": "int",
"description": "Number of custom guide line files present in the code review"
},
{
"name": "codeReviewFindingsCount",
"type": "int",
"description": "Number of findings discovered after running a code review on a source code artifact"
},
{
"name": "codeReviewId",
"type": "string",
"description": "Unique identifier of an code review/scan request, combination of projectId and runId"
},
{
"name": "codeReviewScanName",
"type": "string",
"description": "Unique identifier of project in the workspace in code review tool"
},
{
"name": "codeReviewType",
"type": "string",
"description": "Identifies the type of code review triggered",
"allowedValues": ["FULL_REVIEW", "CODE_DIFF_REVIEW"]
},
{
"name": "codeScanServiceInvocationsDuration",
"type": "int",
Expand Down Expand Up @@ -3194,6 +3236,132 @@
}
]
},
{
"name": "amazonq_qCodeReviewTool_codeScanFailed",
"description": "Captures metrics for failed agentic reviews/scans",
"metadata": [
{
"type": "codeReviewArtifactId",
"required": false
},
{
"type": "codeReviewArtifactSize"
},
{
"type": "codeReviewArtifactType"
},
{
"type": "codeReviewCustomRulesCount"
},
{
"type": "codeReviewId",
"required": false
},
{
"type": "codeReviewScanName",
"required": false
},
{
"type": "codeReviewType"
},
{
"type": "reason",
"required": true
},
{
"type": "result"
}
]
},
{
"name": "amazonq_qCodeReviewTool_codeScanSuccess",
"description": "Captures metrics for successful agentic reviews/scans",
"metadata": [
{
"type": "codeReviewArtifactSize"
},
{
"type": "codeReviewArtifactType"
},
{
"type": "codeReviewCustomRulesCount"
},
{
"type": "codeReviewFindingsCount",
"required": true
},
{
"type": "codeReviewId",
"required": true
},
{
"type": "codeReviewType"
},
{
"type": "result"
}
]
},
{
"name": "amazonq_qCodeReviewTool_codeScanTimeout",
"description": "Captures metrics for timed out agentic reviews/scans",
"metadata": [
{
"type": "codeReviewArtifactSize"
},
{
"type": "codeReviewArtifactType"
},
{
"type": "codeReviewCustomRulesCount"
},
{
"type": "codeReviewId",
"required": true
},
{
"type": "codeReviewType"
},
{
"type": "reason"
},
{
"type": "result"
}
]
},
{
"name": "amazonq_qCodeReviewTool_createUploadUrlFailed",
"description": "Captures metrics for artifact upload failures in agentic reviews/scans",
"metadata": [
{
"type": "codeReviewArtifactSize",
"required": false
},
{
"type": "codeReviewArtifactType"
},
{
"type": "codeReviewScanName"
},
{
"type": "reason",
"required": true
},
{
"type": "result"
}
]
},
{
"name": "amazonq_qCodeReviewTool_missingFileOrFolder",
"description": "Captures metrics for invalid reviews/scans requests",
"metadata": [
{
"type": "result"
}
]
},
{
"name": "amazonq_startConversationInvoke",
"description": "Captures startConversation invocation process",
Expand Down