generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 61
Migrate C# telemetry generator to .NET AWSDK v4 #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bbd4968
Migrate C# telemetry generator to use .NET AWSSDK v4
shruti0085 0d3caac
Add new testServiceModels folder to match updated generator params
shruti0085 c834f7f
Use a partial config file to address the missing DetermineServiceEndp…
shruti0085 5fc72ac
create testservicemodel file as part of script
shruti0085 a4864d5
minor fix
shruti0085 9783685
Bump SDK to latest version
shruti0085 05d6d1a
Bump dotnet tag to latest
shruti0085 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
7,962 changes: 5,610 additions & 2,352 deletions
7,962
telemetry/csharp/AwsToolkit.Telemetry.Events.Tests/Generated/GeneratedCode.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
telemetry/csharp/AwsToolkit.Telemetry.SDK/Custom/AmazonToolkitTelemetryConfig.Partial.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| using Amazon.Runtime; | ||
| using Amazon.Runtime.Endpoints; | ||
| using Amazon.Runtime.Internal; | ||
|
|
||
| namespace Amazon.ToolkitTelemetry | ||
| { | ||
| /// <summary> | ||
| /// Configuration for accessing Amazon ToolkitTelemetry service - Custom partial class | ||
| /// </summary> | ||
| public partial class AmazonToolkitTelemetryConfig | ||
| { | ||
| /// <summary> | ||
| /// Returns the endpoint that will be used for a particular request. | ||
| /// </summary> | ||
| /// <param name="parameters">A Container class for parameters used for endpoint resolution.</param> | ||
| /// <returns>The resolved endpoint for the given request.</returns> | ||
| public override Amazon.Runtime.Endpoints.Endpoint DetermineServiceOperationEndpoint(ServiceOperationEndpointParameters parameters) | ||
| { | ||
| var request = new DefaultRequest(parameters.Request, ServiceId); | ||
| request.AlternateEndpoint = parameters.AlternateEndpoint; | ||
|
|
||
| var requestContext = new RequestContext(false); | ||
| requestContext.ClientConfig = this; | ||
| requestContext.OriginalRequest = parameters.Request; | ||
| requestContext.Request = request; | ||
| var executionContext = new Amazon.Runtime.Internal.ExecutionContext(requestContext, null); | ||
| return new BaseEndpointResolver().GetEndpoint(executionContext); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
telemetry/csharp/client-generator-inputs/telemetry-2017-07-25.customizations.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "file-description": "This file is used by the SDK Client Generator. See telemetry/csharp/README.md for details" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just calling out that this file naturally has a large diff because it isn't updated each time the telemetry definition json file is updated. This file isn't changed as a result of Shruti's change, nor am I concerned about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the generator is auto generated