-
Notifications
You must be signed in to change notification settings - Fork 61
feat(lambda): add telemetry for serverlessLand #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a5ddb0 to
0b074fd
Compare
86cad6e to
9a9fce3
Compare
9a9fce3 to
6b48080
Compare
6b48080 to
8e2fc91
Compare
| ] | ||
| }, | ||
| { | ||
| "name": "lambda_createServerlessLandProject", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the existing appBuilder_ prefix is more relevant?
| "name": "appBuilder_installTool", |
| { | ||
| "name": "iac", | ||
| "type": "string", | ||
| "description": "The IaC being used" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are some examples of values that would go in this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SAM / CDK / Terraform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, naming it "iacType" may help others discover this field in the future. Examples of "xxType" fields:
| "name": "credentialType", |
| "name": "authType", |
| "name": "awsFiletype", |
| "name": "checkType", |
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.