Skip to content

feat(lambda): add telemetry for serverlessLand #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
+20 −0
Merged

feat(lambda): add telemetry for serverlessLand #996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,6 +1379,11 @@
"type": "string",
"description": "HTTP status code for the request (if any) associated with a metric."
},
{
"name": "iac",
"type": "string",
"description": "The IaC being used"
Copy link
Contributor

@justinmk3 justinmk3 Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are some examples of values that would go in this?

Copy link

@seshubaws seshubaws Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAM / CDK / Terraform

Copy link
Contributor

@justinmk3 justinmk3 Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, naming it "iacType" may help others discover this field in the future. Examples of "xxType" fields:

aws-toolkit-common/telemetry/definitions/commonDefinitions.json

Line 958 in 8d8d425

"name": "credentialType",

aws-toolkit-common/telemetry/definitions/commonDefinitions.json

Line 153 in 8d8d425

"name": "authType",

aws-toolkit-common/telemetry/definitions/commonDefinitions.json

Line 174 in 8d8d425

"name": "awsFiletype",

aws-toolkit-common/telemetry/definitions/commonDefinitions.json

Line 235 in 8d8d425

"name": "checkType",

},
{
"name": "iamResourceType",
"type": "string",
Expand Down Expand Up @@ -6201,6 +6206,21 @@
}
]
},
{
"name": "lambda_createServerlessLandProject",
Copy link
Contributor

@justinmk3 justinmk3 Mar 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the existing appBuilder_ prefix is more relevant?

aws-toolkit-common/telemetry/definitions/commonDefinitions.json

Line 2664 in 8e2fc91

"name": "appBuilder_installTool",

"description": "Called when creating a new Serverless Project",
"metadata": [
{
"type": "iac"
},
{
"type": "runtimeString"
},
{
"type": "templateName"
}
]
},
{
"name": "lambda_delete",
"description": "called when deleting lambdas remotely",
Expand Down