Fix region selector drop-down getting cut off by page #4922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
approved these changes
Sep 27, 2024
manodnyab
reviewed
Oct 1, 2024
| @change="handleRegionInput" | ||
| size="1" | ||
| onfocus='this.size=10;' | ||
| onblur='this.size=1;' |
Contributor
There was a problem hiding this comment.
do we need to explicitly set onBlur?
Contributor
Author
There was a problem hiding this comment.
You're right we don't need to explicity set the Onblur if we set it onChange.
Contributor
Author
|
Setting this back to draft, as keyboard navigation reverts the dropdown to its previous behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Changed the behavior of the select element in the WebView for SSO login pages-- this fix applies both to the Q SSO and the Toolkit SSO pages.
Previously the dropdown could render the bottom of the list offscreen where users could not select the bottom options with their mouse. This fix allows users to now be able to see and scroll to the bottom of the list.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.