Skip to content

Fix region selector drop-down getting cut off by page #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix region selector drop-down getting cut off by page #4922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1806d59
Limit select element size
samgst-amazon Sep 26, 2024
78f8501
changelog
samgst-amazon Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/next-release/bugfix-d9d08006-1735-45dc-b030-ca52ed6808ad.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Fix issue where the SSO region selector dropdown was getting cut off at the bottom of the window"
}
24 changes: 24 additions & 0 deletions plugins/core/webview/src/q-ui/components/ssoLoginForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
name="regions"
v-model="selectedRegion"
@change="handleRegionInput"
size="1"
onfocus='this.size=10;'
onblur='this.size=1;'
Copy link
Contributor

@manodnyab manodnyab Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to explicitly set onBlur?

Copy link
Contributor Author

@samgst-amazon samgst-amazon Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right we don't need to explicity set the Onblur if we set it onChange.

onchange='this.size=1; this.blur();'
tabindex="0"
>
<option v-for="region in regions" :key="region.id" :value="region.id">
Expand Down Expand Up @@ -158,6 +162,26 @@ export default defineComponent({
font-size: 12px;
}

.region-select {
height: auto;
box-sizing: border-box;
border-radius: 4px;
padding: 5px;
}

.region-select option {
padding: 5px;
cursor: pointer;
width: auto;
box-sizing: border-box;
}

.region-select:focus {
width: auto !important;
outline: none;
position: absolute;
}

.invalid-start-url {
color: red !important;
margin-left: 3px;
Expand Down
Loading