-
Notifications
You must be signed in to change notification settings - Fork 274
Add an extra . before the file extensions recorded in metrics #4980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d92fded
Add an extra . before the file extensions
manodnyab 35eb87f
Merge remote-tracking branch 'origin/main' into manodnyb/addExtraPeri…
manodnyab 0669073
Merge remote-tracking branch 'origin/main' into manodnyb/addExtraPeri…
manodnyab 278de0d
Merge branch 'main' into manodnyb/addExtraPeriodInMetrics
manodnyab 1d07ce8
addressed feedback
manodnyab aa706d6
Merge remote-tracking branch 'origin/manodnyb/addExtraPeriodInMetrics…
manodnyab d2d5412
detekt
manodnyab 3ab0029
feedback
manodnyab b88fd07
Updated tests
manodnyab 5ae2b40
Merge branch 'main' into manodnyb/addExtraPeriodInMetrics
manodnyab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ class OpenedFileTypeMetricsTest { | |
| @Test | ||
| fun `test addToExistingTelemetryBatch with allowed extension`() { | ||
| service.addToExistingTelemetryBatch("kt") | ||
| assert(service.getOpenedFileTypes().contains("kt")) | ||
| assert(service.getOpenedFileTypes().contains(".kt")) | ||
|
||
| } | ||
|
|
||
| @Test | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use assertj