Add an extra . before the file extensions recorded in metrics #4980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
approved these changes
Oct 22, 2024
| fun `test addToExistingTelemetryBatch with allowed extension`() { | ||
| service.addToExistingTelemetryBatch("kt") | ||
| assert(service.getOpenedFileTypes().contains("kt")) | ||
| assert(service.getOpenedFileTypes().contains(".kt")) |
Contributor
There was a problem hiding this comment.
use assertj
Suggested change
| assert(service.getOpenedFileTypes().contains(".kt")) | |
| assertThat(service.getOpenedFileTypes()).contains(".kt") |
rli
reviewed
Oct 22, 2024
| fun `test addToExistingTelemetryBatch with allowed extension`() { | ||
| service.addToExistingTelemetryBatch("kt") | ||
| assert(service.getOpenedFileTypes().contains("kt")) | ||
| assert(service.getOpenedFileTypes().contains(".kt")) |
Contributor
There was a problem hiding this comment.
also lets try to use JUnit5 for new tests
Contributor
Author
|
/retryBuilds |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.