Don't yield in tight loop when context process hasn't started #5011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodnyab
approved these changes
Oct 25, 2024
Will-ShaoHua
approved these changes
Oct 25, 2024
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
commented
Oct 28, 2024
| } | ||
|
|
||
| // TODO: need better solution for this | ||
| @Suppress("LoopWithTooManyJumpStatements") |
Contributor
Author
There was a problem hiding this comment.
context team to follow up with better solution
rli
changed the title
leigaol
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yield()in while-loop is effectively a busy loop and wastes CPU time#5000
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.