Skip to content

Don't yield in tight loop when context process hasn't started #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Don't yield in tight loop when context process hasn't started #5011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7aa563b
Break out of loop when context process has started
rli Oct 25, 2024
e40ac48
lint
rli Oct 28, 2024
d33a940
lint
rli Oct 28, 2024
1048cba
should not break
rli Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/next-release/bugfix-b18a6b61-e1e9-42dd-952d-7c32ea7a3a19.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Fix pointless busy loop in Amazon Q wasting CPU cycles (#5000)"
}
6 changes: 3 additions & 3 deletions ...ty/src/software/aws/toolkits/jetbrains/services/amazonq/project/ProjectContextProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import kotlinx.coroutines.launch
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.withTimeout
import kotlinx.coroutines.yield
import software.aws.toolkits.core.utils.debug
import software.aws.toolkits.core.utils.error
import software.aws.toolkits.core.utils.getLogger
Expand All @@ -48,14 +47,15 @@
return@launch
}

// TODO: need better solution for this
@Suppress("LoopWithTooManyJumpStatements")
Copy link
Contributor Author

@rli rli Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context team to follow up with better solution

while (true) {
if (encoderServer.isNodeProcessRunning()) {
// TODO: need better solution for this
delay(10000)
initAndIndex()
break
} else {
yield()
delay(10000)

Check warning on line 58 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/project/ProjectContextProvider.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/project/ProjectContextProvider.kt#L58 

Added line #L58 was not covered by tests
}
}
}
Expand Down
Loading