fix supplemental context log latency always says 0ms #5040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
commented
Nov 1, 2024
| LOG.warn { "Failed to fetch supplemental context, empty list." } | ||
| } | ||
|
|
||
| // TODO: fix this latency |
Contributor
Author
There was a problem hiding this comment.
it was indeed correct, the incorrect part is the above log entry
rli
approved these changes
Nov 1, 2024
leigaol
approved these changes
Nov 1, 2024
tverney
pushed a commit
to tverney/aws-toolkit-jetbrains
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logs say it's 0ms everytime
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.