Skip to content

fix supplemental context log latency always says 0ms #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix supplemental context log latency always says 0ms #5040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...re/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererFileContextProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,10 @@ class DefaultCodeWhispererFileContextProvider(private val project: Project) : Fi
}

return supplementalContext?.let {
val latency = System.currentTimeMillis() - startFetchingTimestamp
if (it.contents.isNotEmpty()) {
val logStr = buildString {
append("Successfully fetched supplemental context with strategy ${it.strategy} with ${it.latency} ms")
append("Successfully fetched supplemental context with strategy ${it.strategy} with $latency ms")
it.contents.forEachIndexed { index, chunk ->
append(
"""
Expand All @@ -166,8 +167,7 @@ class DefaultCodeWhispererFileContextProvider(private val project: Project) : Fi
LOG.warn { "Failed to fetch supplemental context, empty list." }
}

// TODO: fix this latency
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was indeed correct, the incorrect part is the above log entry

it.copy(latency = System.currentTimeMillis() - startFetchingTimestamp)
it.copy(latency = latency)
}
} catch (e: TimeoutCancellationException) {
LOG.debug {
Expand Down
Loading