fix(amazonq): download each job's zip to its own directory #5134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodnyab
approved these changes
Nov 26, 2024
ntarakad-aws
approved these changes
Nov 26, 2024
rli
reviewed
Nov 26, 2024
| * If anything goes wrong during this process an exception is thrown. | ||
| */ | ||
| fun create(zipPath: String): CodeModernizerArtifact { | ||
| tempDir = createTempDirectory("codeTransformArtifacts-", UUID.randomUUID().toString()) |
Contributor
There was a problem hiding this comment.
leaking state through the companion object. please have backlog for better encapsulation
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
Co-authored-by: David Hasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When users run consecutive transformations (ex. a Java upgrade with multiple diffs requested, then a SQL conversion), the summary/diff from the 1st transformation would show up when trying to view the summary/diff for the 2nd transformation, because we were re-using a temp directory to store all artifacts.
Solution is to create a new and unique temp directory to hold each transformation job's results.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.