Skip to content

fix(amazonq): download each job's zip to its own directory #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2024
Merged

fix(amazonq): download each job's zip to its own directory #5134

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
445892f
fix(amazonq): download each job's zip to its own directory
Nov 26, 2024
2557aa5
Merge branch 'main' into rivFollowups
dhasani23 Nov 26, 2024
58e4695
Merge branch 'main' into rivFollowups
dhasani23 Nov 26, 2024
8b48d70
Merge branch 'main' into rivFollowups
dhasani23 Nov 26, 2024
2db2bb2
Merge branch 'main' into rivFollowups
dhasani23 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/next-release/bugfix-f486f12a-cb1a-4986-949f-939d600789ae.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Fix(Amazon Q Code Transformation): always show user latest/correct transformation results"
}
4 changes: 3 additions & 1 deletion ...c/software/aws/toolkits/jetbrains/services/codemodernizer/model/CodeModernizerArtifact.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import software.aws.toolkits.core.utils.warn
import software.aws.toolkits.jetbrains.services.codemodernizer.TransformationSummary
import software.aws.toolkits.jetbrains.services.codemodernizer.utils.unzipFile
import java.io.File
import java.util.UUID
import kotlin.io.path.ExperimentalPathApi
import kotlin.io.path.Path
import kotlin.io.path.isDirectory
Expand All @@ -39,7 +40,7 @@ open class CodeModernizerArtifact(

companion object {
private const val MAX_SUPPORTED_VERSION = 1.0
private val tempDir = createTempDirectory("codeTransformArtifacts", null)
private var tempDir = createTempDirectory("codeTransformArtifacts", null)
private const val MANIFEST_FILE_NAME = "manifest.json"
private const val SUMMARY_FILE_NAME = "summary.md"
private const val METRICS_FILE_NAME = "metrics.json"
Expand All @@ -52,6 +53,7 @@ open class CodeModernizerArtifact(
* If anything goes wrong during this process an exception is thrown.
*/
fun create(zipPath: String): CodeModernizerArtifact {
tempDir = createTempDirectory("codeTransformArtifacts-", UUID.randomUUID().toString())
Copy link
Contributor

@rli rli Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaking state through the companion object. please have backlog for better encapsulation

val path = Path(zipPath)
if (path.exists()) {
if (!unzipFile(path, tempDir.toPath())) {
Expand Down
Loading