Skip to content

fix(amazonq): clicking on generated test file does not open file diff #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(amazonq): clicking on generated test file does not open file diff #5196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f163fa
fix the issue that when user can not open file diff by clicking on ge…
Randall-Jiang Dec 11, 2024
3fed7cc
add to-do
Randall-Jiang Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion plugins/amazonq/mynah-ui/src/mynah-ui/ui/connector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,12 @@ export class Connector {
case 'featuredev':
this.featureDevChatConnector.onOpenDiff(tabID, filePath, deleted)
break
/*
TODO: This is for temporary solution to show correct viewdiff panel by clicking the filename
Would re-factor it later for the next task
*/
case 'codetest':
this.codeTestChatConnector.onFileClick(tabID, filePath, deleted, messageId)
this.codeTestChatConnector.onFormButtonClick(tabID, messageId ?? '', {id: "utg_view_diff"})
Copy link
Contributor

@ctlai95 ctlai95 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now but can you please add a TODO to clean this up? Ideally codeTestChatConnector should have a method called onOpenDiff instead of calling onFormButtonClick which should only be used by form buttons.

break
}
}
Expand Down
Loading