Skip to content

Conversation

@samgst-amazon
Copy link
Contributor

@samgst-amazon samgst-amazon commented Jan 21, 2025

CodewhispererSettings state component was not saving some of its settings across restarts, this change fixes that, along with setting roamingType to default to avoid sync issues.

If there are multiple components that store state in the same file, they must have the same roamingType attribute value.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

The intValue and StringValue used by the state class were missing the
@get:Property tag that the value property had, which meant they were not being properly serialized in the xml file.

Adding the annotation tag to the other properties allows for serialization of these values on IDE exit.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested a review from a team as a code owner January 21, 2025 19:32
@github-actions
Copy link

github-actions bot commented Jan 21, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@rli rli merged commit 8006ae4 into main Jan 22, 2025
14 of 15 checks passed
@rli rli deleted the samgst/CodewhispererSettingsStringSaving branch January 22, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants