fix(generic chat): fix chat panel open-settings not opening the configuration panel correctly #5286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leigaol
approved these changes
Jan 21, 2025
manodnyab
approved these changes
Jan 22, 2025
Will-ShaoHua
commented
Jan 22, 2025
Comment on lines
-607
to
-615
| if (isFormButtonCodeTransform(action.id)) { | ||
| this.codeTransformChatConnector.onFormButtonClick(tabId, action) | ||
| } else if (isFormButtonCodeScan(action.id)) { | ||
| this.codeScanChatConnector.onFormButtonClick(tabId, action) | ||
| } else if (isFormButtonCodeTest(action.id)) { | ||
| this.codeTestChatConnector.onFormButtonClick(tabId, messageId, action) | ||
| } else if (action.id === 'doc') { | ||
| this.docChatConnector.onFormButtonClick(tabId, action) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
zixlin7
approved these changes
Jan 22, 2025
rli
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
RC
It seems to be a small regression after RIV refactoring work and this code snippet will be never reached
https://github.com/aws/aws-toolkit-jetbrains/blob/main/plugins/amazonq/mynah-ui/src/mynah-ui/ui/connector.ts#L598-L627
from
https://github.com/aws/aws-toolkit-jetbrains/blob/main/plugins/amazonq/mynah-ui/src/mynah-ui/ui/connector.ts#L539-L563
Before
Screen.Recording.2025-01-21.at.3.07.59.PM.mov
After
Screen.Recording.2025-01-21.at.3.06.02.PM.mov
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.