fix(amazonq): add boundary check to UserModificationTracker to prevent IndexOutOfBoundsException #5312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewyuq
approved these changes
Jan 30, 2025
Contributor
rli
reviewed
Jan 31, 2025
.../toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt
Show resolved
Hide resolved
rli
approved these changes
Jan 31, 2025
Will-ShaoHua
approved these changes
Jan 31, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt
Fixed
Show fixed
Hide fixed
rli
requested changes
Feb 1, 2025
.../toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt
Show resolved
Hide resolved
This reverts commit d9453ea.
rli
approved these changes
Feb 3, 2025
gandhi-21
pushed a commit
to gandhi-21/aws-toolkit-jetbrains
that referenced
this pull request
Feb 26, 2025
…t IndexOutOfBoundsException (aws#5312) * add boundary check for userModificationTracker * add chaneglog * Update bugfix-24d6621e-32d3-45c5-a996-66232724e425.json This reverts commit d9453ea. --------- Co-authored-by: Richard Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR improves the emitTelemetryOnSuggestion method in the CodeWhispererUserModificationTracker class. Specifically:
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.