-
Notifications
You must be signed in to change notification settings - Fork 274
bug fix(amazonq): fix an issue where user action is accept but telemetry is reject #5319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
approved these changes
Feb 3, 2025
rli
approved these changes
Feb 3, 2025
...rc/software/aws/toolkits/jetbrains/services/codewhisperer/popup/CodeWhispererPopupManager.kt
Show resolved
Hide resolved
...rc/software/aws/toolkits/jetbrains/services/codewhisperer/popup/CodeWhispererPopupManager.kt
Show resolved
Hide resolved
KevinDing1
pushed a commit
to KevinDing1/aws-toolkit-jetbrains
that referenced
this pull request
Feb 6, 2025
…try is reject (aws#5319) * bug fix(amazonq): fix an issue where user action is accept but telemetry is reject * detekt * fix increment logic when IntelliSense is showing up * Change to use a semaphore
6 tasks
andrewyuq
added a commit
to andrewyuq/aws-toolkit-jetbrains
that referenced
this pull request
Feb 10, 2025
gandhi-21
pushed a commit
to gandhi-21/aws-toolkit-jetbrains
that referenced
this pull request
Feb 26, 2025
…try is reject (aws#5319) * bug fix(amazonq): fix an issue where user action is accept but telemetry is reject * detekt * fix increment logic when IntelliSense is showing up * Change to use a semaphore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shouldEditorCancelPopup variable should increment/decrement in-pair inside
dontClosePopupAndRunlogic and theCodeWhispererPopupIntelliSenseAcceptListenerlogic, but there was some race condition that makesCodeWhispererPopupIntelliSenseAcceptListener's setting false afterdontClosePopupAndRun's setting true,so now making it a semaphore-like val to make sure it was updated properly.
The common scenario is as follows:
beforeItemSelectedis not triggered to make it to false, (so a part of this fix is to make thebeforeItemSelectedlogic tolookupShownlogic and make it an int so it can be incremented twice so decrementing doesn't completely reset it.)Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.