Skip to content

fix(amazonq): /test will ignore additonal file types from payload #5389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix(amazonq): /test will ignore additonal file types from payload #5389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e749c
Adding more extensions and no extension files to test generation usec…
ashishrp-aws Feb 19, 2025
57134a5
Merge branch 'main' into extensionlist
ashishrp-aws Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...src/software/aws/toolkits/jetbrains/services/codewhisperer/util/GitIgnoreFilteringUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ class GitIgnoreFilteringUtil(
"*.a",
"*.map",
"*.graph",
"*.so"
"*.so",
"*.csv",
"*.dylib",
"*.parquet",
"*.xlsx"
)
)
}
Expand Down Expand Up @@ -101,6 +105,18 @@ class GitIgnoreFilteringUtil(

suspend fun ignoreFile(file: VirtualFile): Boolean {
// this method reads like something a JS dev would write and doesn't do what the author thinks

// ignores no extension files for test generation use case.
val allowedNoExtFiles = setOf("Config", "Dockerfile", "README")
if (useCase == CodeWhispererConstants.FeatureName.TEST_GENERATION &&
!file.isDirectory &&
file.extension.isNullOrEmpty() &&
!allowedNoExtFiles.any {
it.equals(file.name, ignoreCase = true)
}
) {
return true
}
val deferredResults = ignorePatternsWithGitIgnore.map { pattern ->
withContext(coroutineContext) {
// avoid partial match (pattern.containsMatchIn) since it causes us matching files
Expand Down
Loading