Skip to content

Conversation

@samgst-amazon
Copy link
Contributor

Previously only emitted for new file open events, and did emit for files that had been opened in previous sessions that were still open on IDE start.

This change is needed for inline completion to work properly, as didOpen events are used to populate server's textDocuments.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested a review from a team as a code owner March 21, 2025 16:53
@github-actions
Copy link

github-actions bot commented Mar 21, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@samgst-amazon samgst-amazon enabled auto-merge (squash) March 31, 2025 22:54
@samgst-amazon samgst-amazon disabled auto-merge April 1, 2025 18:05
@samgst-amazon samgst-amazon merged commit 5f752ca into feature/q-lsp Apr 1, 2025
16 of 18 checks passed
@samgst-amazon samgst-amazon deleted the samgst/q-lsp-didOpen-init branch April 1, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants