Skip to content

Conversation

@chengoramazon
Copy link
Contributor

@chengoramazon chengoramazon commented Mar 24, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Add __CODEWHISPERER_ENDPOINT environment variable support to override
endpoint during testing. Falls back to registry value if not set. This environment variable is consistent with VS Code implementation.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chengoramazon chengoramazon requested a review from a team as a code owner March 24, 2025 20:47
object Config {
val CODEWHISPERER_ENDPOINT
get() = Registry.get("amazon.q.endpoint").asString()
get() = System.getenv("__CODEWHISPERER_ENDPOINT") ?: Registry.get("amazon.q.endpoint").asString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that we will likely change the semantics of how this works, due to other ongoing initiatives involving the service endpoint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Once we roll out the new implementation, we should make sure to include this change - it'll affect how Q teams run UI tests in their pipelines.

@chengoramazon
Copy link
Contributor Author

/retryBuilds

@chengoramazon
Copy link
Contributor Author

/retryBuilds

@rli rli merged commit 749a163 into aws:main Mar 26, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants