Skip to content

Conversation

@manodnyab
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Support all the / commands

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manodnyab manodnyab requested review from a team as code owners May 6, 2025 19:54
@manodnyab manodnyab changed the title Integrate named agents with chat feat(amazonq): Integrate named agents with chat May 6, 2025
@github-actions
Copy link

github-actions bot commented May 6, 2025

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

val node = serializer.toNode(json)
when (node.command) {
// this is sent when the named agents UI is ready
"ui-is-ready" -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor Author

@manodnyab manodnyab May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know!!

}


export type MynahUIRef = { mynahUI: MynahUI | undefined }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why undefined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is lazily injected once the connector is initialized, so it'll be undefined before


window.fqnExtractor = new FqnExtractor();

export const initiateAdapter = (showWelcomePage: boolean,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide reference to VSC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have a reference in VSC. The webpack bundles this file and to be able to access its contents need an instance of the class

@manodnyab manodnyab merged commit da5ba25 into feature/q-lsp-chat May 7, 2025
14 of 16 checks passed
@manodnyab manodnyab deleted the manodnyb/supportAgentsInFlare2 branch May 7, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants