fix(amazonq): fix issue where history load crashes LSP #5690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chat UI bundle contains unicode, which is incorrectly loaded as ASCII when packaged as a webpack bundle. On Flare LSP request `aws/chat/openTab`, we forward the message to Mynah UI, which subsequently fails if the body contains Java-formatted markdown as it triggers the incorrectly parsed unicode. The Flare [chat wrapper](https://github.com/aws/language-servers/blame/547ecafb561fd3d6bf7a264def829160901dd23a/chat-client/src/client/mynahUi.ts#L989-L991) subsequently does not respond with the `onOpenTab` callback and the LSP times out and exits the process. Fix by explicitly loading assets as UTF-8
manodnyab
approved these changes
May 8, 2025
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat UI bundle contains unicode, which is incorrectly loaded as ASCII when packaged as a webpack bundle.
On Flare LSP request
aws/chat/openTab, we forward the message to Mynah UI, which subsequently fails if the body contains Java-formatted markdown as it triggers the incorrectly parsed unicode.The Flare chat wrapper subsequently does not respond with the
onOpenTabcallback and the LSP times out and exits the process.Fix by explicitly loading assets as UTF-8
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.