Skip to content

telemetry(amazonq): expose FileCreationFailed exceptions #5696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

telemetry(amazonq): expose FileCreationFailed exceptions #5696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6002f9b
telemetry(amazonq): expose FileCreationFailed exceptions
akhamis-amzn May 9, 2025
ba70e3e
Merge branch 'main' into add-file-creation-error
akhamis-amzn May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ty/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevExceptions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@
class PromptRefusalException(operation: String, desc: String?, cause: Throwable? = null) :
ClientException(message("amazonqFeatureDev.exception.prompt_refusal"), operation, desc, cause)

class FileCreationFailedException(operation: String, desc: String?, cause: Throwable? = null) :
ServiceException(message("amazonqFeatureDev.exception.failed_generation"), operation, desc, cause)

Check failure on line 86 in plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevExceptions.kt

View workflow job for this annotation

GitHub Actions / qodana

Invalid property key 

'amazonqFeatureDev.exception.failed_generation' doesn't appear to be a valid property key

Check failure

Code scanning / QDJVMC

Invalid property key Error

'amazonqFeatureDev.exception.failed_generation' doesn't appear to be a valid property key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment below is likely correct. Is there a definition for amazonqFeatureDev.exception.failed_generation in the strings file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified offline that it does exist


class ThrottlingException(operation: String, desc: String?, cause: Throwable? = null) :
ClientException(message("amazonqFeatureDev.exception.throttling"), operation, desc, cause)

Expand Down
5 changes: 5 additions & 0 deletions ...software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.EmptyPatchExce
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FEATURE_NAME
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FeatureDevException
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FeatureDevOperation
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FileCreationFailedException
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.GuardrailsException
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.NoChangeRequiredException
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.PromptRefusalException
Expand Down Expand Up @@ -261,6 +262,10 @@ private suspend fun CodeGenerationState.generateCode(
codeGenerationResultState.codeGenerationStatusDetail()?.contains(
"EmptyPatch",
),
-> throw FileCreationFailedException(operation = FeatureDevOperation.GenerateCode.toString(), desc = "File creation failed")
codeGenerationResultState.codeGenerationStatusDetail()?.contains(
"FileCreationFailed",
),
-> {
if (codeGenerationResultState.codeGenerationStatusDetail().contains("NO_CHANGE_REQUIRED")) {
throw NoChangeRequiredException(operation = FeatureDevOperation.GenerateCode.toString(), desc = "No change required")
Expand Down
Loading