telemetry(amazonq): expose FileCreationFailed exceptions #5696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...unity/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevExceptions.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevExceptions.kt
Fixed
Show fixed
Hide fixed
akhamis-amzn
force-pushed
the
add-file-creation-error
branch
from
6a3560a to
6002f9b
Compare
| ClientException(message("amazonqFeatureDev.exception.prompt_refusal"), operation, desc, cause) | ||
|
|
||
| class FileCreationFailedException(operation: String, desc: String?, cause: Throwable? = null) : | ||
| ServiceException(message("amazonqFeatureDev.exception.failed_generation"), operation, desc, cause) |
Check failure
Code scanning / QDJVMC
Invalid property key Error
neilk-aws
reviewed
May 9, 2025
| ClientException(message("amazonqFeatureDev.exception.prompt_refusal"), operation, desc, cause) | ||
|
|
||
| class FileCreationFailedException(operation: String, desc: String?, cause: Throwable? = null) : | ||
| ServiceException(message("amazonqFeatureDev.exception.failed_generation"), operation, desc, cause) |
There was a problem hiding this comment.
The comment below is likely correct. Is there a definition for amazonqFeatureDev.exception.failed_generation in the strings file?
There was a problem hiding this comment.
Verified offline that it does exist
neilk-aws
approved these changes
May 9, 2025
| ClientException(message("amazonqFeatureDev.exception.prompt_refusal"), operation, desc, cause) | ||
|
|
||
| class FileCreationFailedException(operation: String, desc: String?, cause: Throwable? = null) : | ||
| ServiceException(message("amazonqFeatureDev.exception.failed_generation"), operation, desc, cause) |
There was a problem hiding this comment.
Verified offline that it does exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FileCreationFailed exceptions are displayed as UnknownException in telemetry. This exception is new and we want to separate this out from other unknown exceptions.
Solution
Return API service error with FileCreationFailedException
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.