fix(core): don't retry on InvalidGrantException because it is terminal #5764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is not a retryable exception
manodnyab
approved these changes
May 29, 2025
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
chungjac
added a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Oct 17, 2025
## Problem: ``` // As part of SIM IDE-10703, there was an assumption that retrying on InvalidGrantException // may be useful. This may not be the case anymore and if more research is done, this may not be needed. ``` ## Solution: We do not want to retry on `InvalidGrantException` as this is a non-retryable exception Brings parity with JB: aws/aws-toolkit-jetbrains#5764 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not a retryable exception. requested internally by IdC team.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.