Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Oct 17, 2025

Problem:

// As part of SIM IDE-10703, there was an assumption that retrying on InvalidGrantException
// may be useful. This may not be the case anymore and if more research is done, this may not be needed.

Solution:

We do not want to retry on InvalidGrantException as this is a non-retryable exception
Brings parity with JB: aws/aws-toolkit-jetbrains#5764


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner October 17, 2025 22:55
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

return err.name === 'InvalidGrantException'
// Previously retried InvalidGrantException on the basis that it may be useful
// We have found that this is not a retryable exception
return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so essentially we can delete updatedRetryDecider

Copy link
Contributor Author

@chungjac chungjac Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't defaultRetryDecider still might have some errors which aws deems "safe" to retry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i see, just use the defaultRetryDecider.

@chungjac chungjac merged commit 283311a into aws:master Oct 17, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants