-
Notifications
You must be signed in to change notification settings - Fork 728
fix(auth): do not retry on InvalidGrantException #8205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
| return err.name === 'InvalidGrantException' | ||
| // Previously retried InvalidGrantException on the basis that it may be useful | ||
| // We have found that this is not a retryable exception | ||
| return false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so essentially we can delete updatedRetryDecider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't defaultRetryDecider still might have some errors which aws deems "safe" to retry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i see, just use the defaultRetryDecider.
Problem:
Solution:
We do not want to retry on
InvalidGrantExceptionas this is a non-retryable exceptionBrings parity with JB: aws/aws-toolkit-jetbrains#5764
feature/xbranches will not be squash-merged at release time.