Skip to content

fix(auth): do not retry on InvalidGrantException #8205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix(auth): do not retry on InvalidGrantException #8205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions packages/core/src/auth/sso/clients.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import { getLogger } from '../../shared/logger/logger'
import { SsoAccessTokenProvider } from './ssoAccessTokenProvider'
import { AwsClientResponseError, isClientFault } from '../../shared/errors'
import { DevSettings } from '../../shared/settings'
import { SdkError } from '@aws-sdk/types'
import { HttpRequest, HttpResponse } from '@smithy/protocol-http'
import { StandardRetryStrategy, defaultRetryDecider } from '@smithy/middleware-retry'
import { AuthenticationFlow } from './model'
Expand Down Expand Up @@ -104,22 +103,12 @@ export class OidcClient {
}

public static create(region: string) {
const updatedRetryDecider = (err: SdkError) => {
if (defaultRetryDecider(err)) {
return true
}

// As part of SIM IDE-10703, there was an assumption that retrying on InvalidGrantException
// may be useful. This may not be the case anymore and if more research is done, this may not be needed.
// TODO: setup some telemetry to see if there are any successes on a subsequent retry for this case.
return err.name === 'InvalidGrantException'
}
const client = new SSOOIDC({
region,
endpoint: DevSettings.instance.get('endpoints', {})['ssooidc'],
retryStrategy: new StandardRetryStrategy(
() => Promise.resolve(3), // Maximum number of retries
{ retryDecider: updatedRetryDecider }
{ retryDecider: defaultRetryDecider }
),
customUserAgent: getUserAgent({ includePlatform: true, includeClientId: true }),
requestHandler: {
Expand Down
Loading