Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Fix auto-suggestions being shown when suggestions are paused"
}
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ class QInlineCompletionProvider(private val cs: CoroutineScope) : InlineCompleti
val project = editor.project ?: return false

if (!isQConnected(project)) return false
if (!CodeWhispererExplorerActionManager.getInstance().isAutoEnabled() && event.isManualCall()) return false
if (!CodeWhispererExplorerActionManager.getInstance().isAutoEnabled()) return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this will disable completions completely if auto is not on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want it to disable when auto is not on right? Auto is the pause and resume suggestions in the dropdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, enabling manual call for when auto-suggestions are paused

if (QRegionProfileManager.getInstance().hasValidConnectionButNoActiveProfile(project)) return false
return true
}
Expand Down
Loading