fix(amazonq): Disable auto-suggestions when paused in the status bar #5880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
reviewed
Jul 3, 2025
|
|
||
| if (!isQConnected(project)) return false | ||
| if (!CodeWhispererExplorerActionManager.getInstance().isAutoEnabled() && event.isManualCall()) return false | ||
| if (!CodeWhispererExplorerActionManager.getInstance().isAutoEnabled()) return false |
There was a problem hiding this comment.
won't this will disable completions completely if auto is not on
There was a problem hiding this comment.
We want it to disable when auto is not on right? Auto is the pause and resume suggestions in the dropdown
There was a problem hiding this comment.
Discussed offline, enabling manual call for when auto-suggestions are paused
samgst-amazon
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Inline completion suggestions were being shown even when paused from the status bar.
Removing the manual call filter that disables the provider only when call is manual
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.