fix(amazonq): change to use withExtensionFilter to hide unallowed files #5909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhangok
changed the title
manodnyab
reviewed
Jul 24, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type" : "bugfix", | |||
| "description" : "change to use withExtensionFilter to hide unallowed files when selecting image" | |||
There was a problem hiding this comment.
Suggested change
| "description" : "change to use withExtensionFilter to hide unallowed files when selecting image" | |
| "description" : "Fix unsupported files being shown in file picker when selecting images for adding image context in Windows" |
| if (isExtensionFilterSupported()) { | ||
| // Use reflection to call withExtensionFilter which is only available in 2024.3+ | ||
| try { | ||
| val method = this.javaClass.getMethod("withExtensionFilter", String::class.java, Array<String>::class.java) |
There was a problem hiding this comment.
we have different source modules that support code compatibility based on versions. Instead of using reflection, we can use those? This code can be added to src-243+. Will this still be an issue on 242?
manodnyab
reviewed
Jul 25, 2025
| * The withExtensionFilter method was introduced in IntelliJ Platform 2024.3 (baseline version 243). | ||
| * For older versions, fall back to withFileFilter which provides similar functionality | ||
| */ | ||
| interface FileChooserCompat { |
There was a problem hiding this comment.
Do we need this interface, can we just add a separate function in the separate modules?
manodnyab
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem
Solution
Starting Version 2024.3, use
withExtensionFilterto hide unallowed files.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.