Skip to content

Conversation

@chengoramazon
Copy link
Contributor

Problem

  • Q dev won't be able to generate code for unrelated prompts. (e.g. explain the code)
  • It would be a bad CX if Q fail to generate code without guiding users the proper use cases.

Solution

  • Handle no code change required explicitly.
  • Allow users to provide more details
res.mov

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chengoramazon chengoramazon requested review from a team as code owners October 3, 2024 21:21
@github-actions
Copy link

github-actions bot commented Oct 3, 2024

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Copy link
Member

@osdemah osdemah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpinkney-aws jpinkney-aws merged commit c529794 into aws:master Oct 7, 2024
8 of 10 checks passed
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Q dev handle no change required"
Copy link
Contributor

@justinmk3 justinmk3 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a changelog. Please review the changelog guidelines. This doesn't meet those guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants