Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

@jpinkney-aws jpinkney-aws commented Oct 4, 2024

Problem

  • Follow up on the previous remove trackPerformance PR, we no longer need collectFiles telemetry since the data isn't reliable in the extension host
  • integ tests are failing because of this

Solution

  • Remove the instrumentation

Problem:
- Follow up on the previous remove trackPerformance PR, we no longer need collectFiles telemetry

Solution:
- Remove the instrumentation
@jpinkney-aws jpinkney-aws requested a review from a team as a code owner October 4, 2024 13:17
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@Hweinstock
Copy link
Contributor

So if we rebase to current master, this should resolve the final integ tests failing?

@justinmk3
Copy link
Contributor

new integ failures:

  1) visualizeStateMachine
       opens up a webview when there is an active text editor:
     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert_1.default.ok(result)

      at Context.<anonymous> (/codebuild/output/src3721222019/src/github.com/aws/aws-toolkit-vscode/packages/core/src/testInteg/stepFunctions/visualizeStateMachine.test.ts:108:16)

  2) visualizeStateMachine
       correctly displays content when given a sample state machine:
     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert_1.default.ok(result)

      at Context.<anonymous> (/codebuild/output/src3721222019/src/github.com/aws/aws-toolkit-vscode/packages/core/src/testInteg/stepFunctions/visualizeStateMachine.test.ts:117:16)

  3) visualizeStateMachine
       correctly displays content when given a sample state machine in yaml:
     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert_1.default.ok(result)

      at Context.<anonymous> (/codebuild/output/src3721222019/src/github.com/aws/aws-toolkit-vscode/packages/core/src/testInteg/stepFunctions/visualizeStateMachine.test.ts:140:16)

  4) visualizeStateMachine
       update webview is triggered when user saves correct text editor:
     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert_1.default.ok(result)

      at Context.<anonymous> (/codebuild/output/src3721222019/src/github.com/aws/aws-toolkit-vscode/packages/core/src/testInteg/stepFunctions/visualizeStateMachine.test.ts:164:16)

  5) visualizeStateMachine
       doesnt update the graph if a seperate file is opened or modified:
     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert_1.default.ok(result)

      at Context.<anonymous> (/codebuild/output/src3721222019/src/github.com/aws/aws-toolkit-vscode/packages/core/src/testInteg/stepFunctions/visualizeStateMachine.test.ts:197:16)

globalSetup: after()

@Hweinstock
Copy link
Contributor

I believe these are fixed in #5724.

@justinmk3 justinmk3 merged commit 907754c into master Oct 7, 2024
34 of 40 checks passed
@justinmk3 justinmk3 deleted the jpinkney-aws/remove-telem branch October 7, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants