Skip to content

deps(ci node): update node in ci to 18.x [WIP] #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 23, 2024
+11 −8
Merged

deps(ci node): update node in ci to 18.x [WIP] #5810

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3a442e8
bump node
Hweinstock Oct 17, 2024
9d3cc75
bump vscode-electron-test version
Hweinstock Oct 17, 2024
9de41a3
bump version back up
Hweinstock Oct 17, 2024
0bb02f9
bump to 2.3.10
Hweinstock Oct 17, 2024
f604193
bump to 2.4.0
Hweinstock Oct 17, 2024
3299354
bump version to 2.4.1 (latest)
Hweinstock Oct 17, 2024
3190306
bump windows down temporarily
Hweinstock Oct 18, 2024
6e81334
debump test-electron
Hweinstock Oct 18, 2024
1e8787d
undo changes
Hweinstock Oct 18, 2024
9f6b418
rebump to node18
Hweinstock Oct 18, 2024
784e73d
try bumping to node 20
Hweinstock Oct 18, 2024
26b2883
rebump to 18
Hweinstock Oct 18, 2024
69d629f
add debugging statement for ci
Hweinstock Oct 21, 2024
77073e0
Update packages/core/scripts/test/launchTestUtilities.ts
Hweinstock Oct 21, 2024
b025796
add shell true to avoid error
Hweinstock Oct 21, 2024
4f3e056
run in shell windows only
Hweinstock Oct 21, 2024
d667a91
Merge branch 'master' into cinodebump
Hweinstock Oct 21, 2024
150bdc8
remove shell command temp
Hweinstock Oct 21, 2024
532d5d8
remove dependency on project in scripts
Hweinstock Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x]
node-version: [18.x]
vscode-version: [stable]
env:
NODE_OPTIONS: '--max-old-space-size=8192'
Expand All @@ -62,7 +62,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x]
node-version: [18.x]
vscode-version: [minimum, stable, insiders]
env:
VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
strategy:
fail-fast: true
matrix:
node-version: [16.x]
node-version: [18.x]
vscode-version: [stable, insiders]
env:
VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
Expand All @@ -158,7 +158,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x]
node-version: [18.x]
vscode-version: [stable, insiders]
env:
VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
Expand Down
2 changes: 1 addition & 1 deletion buildspec/linuxIntegrationTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ phases:
install:
run-as: root
runtime-versions:
nodejs: 16
nodejs: 18
dotnet: 6.0
java: latest

Expand Down
2 changes: 1 addition & 1 deletion buildspec/linuxTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ phases:
install:
run-as: root
runtime-versions:
nodejs: 16
nodejs: 18
commands:
- bash buildspec/shared/linux-install.sh

Expand Down
2 changes: 1 addition & 1 deletion buildspec/packageTestVsix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ phases:
install:
run-as: root
runtime-versions:
nodejs: 16
nodejs: 18
commands:
- bash buildspec/shared/linux-install.sh

Expand Down
2 changes: 1 addition & 1 deletion buildspec/windowsTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ env:
phases:
install:
runtime-versions:
nodejs: 16
nodejs: 18
commands:
- |
if(-Not($Env:CODECOV_TOKEN -eq $null)) {
Expand Down
1 change: 1 addition & 0 deletions packages/core/scripts/test/launchTestUtilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ async function invokeVSCodeCli(vsCodeExecutablePath: string, args: string[]): Pr

if (spawnResult.status !== 0) {
console.log('output: %s', spawnResult.output)
console.log('error: %s ', spawnResult.error)
throw new Error(`VS Code CLI command failed (exit-code: ${spawnResult.status}): ${cli} ${cmdArgs}`)
}

Expand Down
Loading