feat(amazonq): Add inline chat #5835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
justinmk3
reviewed
Oct 25, 2024
| import * as vscode from 'vscode' | ||
| import { InlineTask, TextDiff } from '../controller/inlineTask' | ||
|
|
||
| export function computeDiff(response: string, inlineTask: InlineTask, isPartialDiff: boolean): TextDiff[] | undefined { |
Contributor
There was a problem hiding this comment.
@ivikash is there diff-related code on master or some other branch that might overlap with this module?
Member
There was a problem hiding this comment.
The existing implementation generates a diff by
- Creating a temporary clone of the file in
tempDir - Overwriting the selected Range with the new code.
Trying to reuse the same logic, here will make it more complicated instead.
justinmk3
reviewed
Oct 25, 2024
justinmk3
reviewed
Oct 25, 2024
justinmk3
reviewed
Oct 25, 2024
Contributor
Author
|
@justinmk3 what are next steps to merge this? |
Contributor
|
This needs a changelog item. |
zixlin7
approved these changes
Oct 28, 2024
hayemaxi
reviewed
Oct 28, 2024
justinmk3
reviewed
Oct 28, 2024
justinmk3
reviewed
Oct 28, 2024
justinmk3
reviewed
Oct 28, 2024
hayemaxi
reviewed
Oct 28, 2024
packages/amazonq/src/inlineChat/controller/inlineChatController.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Oct 28, 2024
justinmk3
reviewed
Oct 28, 2024
justinmk3
reviewed
Oct 28, 2024
justinmk3
reviewed
Oct 28, 2024
justinmk3
approved these changes
Oct 28, 2024
leigaol
reviewed
Oct 28, 2024
leigaol
reviewed
Oct 28, 2024
leigaol
approved these changes
Oct 28, 2024
hayemaxi
added a commit
that referenced
this pull request
Oct 29, 2024
Re-syncs icons after discrepancy in #5835 --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adds inline chat to Amazon Q
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.