Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

We have no documentation showing what latencies we are measuring for amazon q chat

Solution

Add documentation

Direct link: https://github.com/jpinkney-aws/aws-toolkit-vscode/blob/4c7ae0ae0c8d0e4525b68da487bd43c4c1b7884b/docs/telemetry-perf.md


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner October 25, 2024 13:55

### cwsprChatTimeToFirstChunk

The time between when the conversation id was created and when we got back the first usable result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the conversation id was created

Can this be reworded to something higher level like "when the first conversation message is sent" (IIUC)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "when the conversation stream was created"

participant user as User
participant chat as Chat UI
participant vscode as VSCode
participant generateResponse as Generate response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the service client?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its technically the name of the function that executes the calls to the backend, I wanted it to live seperate from the vscode extension host since the chat message -> vscode extension host happens completely seperately from that function. Let me know if theres a better name you suggest

end
```

### cwsprChatTimeBetweenChunks
Copy link
Contributor

@nkomonen-amazon nkomonen-amazon Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify somewhere what a "chunk" is in a chat context?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the description to include
"successive pieces" of data rather than "successive chunks". Does that make more sense?

@jpinkney-aws jpinkney-aws merged commit cee0fa3 into aws:master Nov 4, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants