fix(amazonq): limit maximum size of supplementalContext being sent #5877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
changed the title
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
leigaol
reviewed
Oct 28, 2024
packages/amazonq/.changes/next-release/Bug Fix-279c3a22-246e-41ca-9a42-3e446cdb9565.json
Outdated
Show resolved
Hide resolved
leigaol
approved these changes
Oct 28, 2024
hayemaxi
reviewed
Oct 28, 2024
packages/amazonq/.changes/next-release/Bug Fix-279c3a22-246e-41ca-9a42-3e446cdb9565.json
Outdated
Show resolved
Hide resolved
hayemaxi
reviewed
Oct 28, 2024
packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
Show resolved
Hide resolved
hayemaxi
reviewed
Oct 28, 2024
packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
Show resolved
Hide resolved
hayemaxi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We found there were lots of cases where open tabs context sent from the plugins with total length > 10240 chars long, which will result in
validationExceptionerror while users trigger inline completion service.Solution
Limit maximum length of supplemental context added in the result set and meanwhile Q team is conducting investigation to root cause it.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.