Skip to content

fix(amazonq): limit maximum size of supplementalContext being sent #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 28, 2024
Merged

fix(amazonq): limit maximum size of supplementalContext being sent #5877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5518a13
limit maximum size of supplementalContext being sent
Will-ShaoHua Oct 28, 2024
ef1f174
update constant
Will-ShaoHua Oct 28, 2024
809b409
patch
Will-ShaoHua Oct 28, 2024
cfd0e87
address comments
Will-ShaoHua Oct 28, 2024
15ba9f8
patch
Will-ShaoHua Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-279c3a22-246e-41ca-9a42-3e446cdb9565.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Inline Suggestions: Occasional `ValidationException` if user context has too many characters."
}
1 change: 1 addition & 0 deletions packages/core/src/codewhisperer/models/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,7 @@ export const crossFileContextConfig = {
numberOfChunkToFetch: 60,
topK: 3,
numberOfLinesEachChunk: 50,
maximumTotalLength: 20480,
}

export const utgConfig = {
Expand Down
7 changes: 7 additions & 0 deletions packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,16 @@ export async function fetchSupplementalContextForSrcV1(

// Step 4: Transform best chunks to supplemental contexts
const supplementalContexts: CodeWhispererSupplementalContextItem[] = []
let totalLength = 0
for (const chunk of bestChunks) {
throwIfCancelled(cancellationToken)

totalLength += chunk.nextContent.length

if (totalLength > crossFileContextConfig.maximumTotalLength) {
break
}

supplementalContexts.push({
filePath: chunk.fileName,
content: chunk.nextContent,
Expand Down
Loading