Skip to content

Conversation

@michaellandi
Copy link
Contributor

@michaellandi michaellandi commented Nov 26, 2024

Problem

Dockerfile files are not currently supported by /dev

Solution

Add a list of file prefixes that are considered code files for /dev. This approach supports not only Dockerfile but also popular variants of this such as Dockerfile.build, Dockerfile-prod, etc.

I manually tested some prompts in /dev with requests. I set breakpoints to see that the file was being zipped up in workspace upload.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaellandi michaellandi requested a review from a team as a code owner November 26, 2024 02:34
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@avi-alpert
Copy link
Contributor

Since this is a commit to public master please include a change log as described in CONTRIBUTING.md

@michaellandi
Copy link
Contributor Author

Since this is a commit to public master please include a change log as described in CONTRIBUTING.md

Done, thanks.

@michaellandi michaellandi marked this pull request as draft November 26, 2024 03:56
@michaellandi michaellandi marked this pull request as ready for review November 26, 2024 04:36
@jpinkney-aws jpinkney-aws merged commit 2257bd0 into aws:master Nov 26, 2024
23 of 25 checks passed
justinmk3 pushed a commit that referenced this pull request Dec 6, 2024
## Problem
Nested `Dockerfile` files were not supported with
#6107

## Solution
Look at path basename when comparing file to list of well known files.
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
Nested `Dockerfile` files were not supported with
aws#6107

Look at path basename when comparing file to list of well known files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants