fix(amazonq): Improved LLM code review for file review #6162
Conversation
|
Then it's not a "fix". But based on your description, I can imagine a way to describe the improvement to customers, something like: "Improved performance of LLM based code review". Whenever there's any kind of improvement, it's worth mentioning. And conversely, if something is not being improved then it's not a "fix" or a "feat". |
| CodeWhispererConstants.CodeAnalysisScope.FILE_ON_DEMAND | ||
| ) | ||
| const gitDiffContent = `+++ b/${zipEntryPath}` | ||
| zip.addFile(ZipConstants.codeDiffFilePath, Buffer.from(gitDiffContent, 'utf-8')) |
There was a problem hiding this comment.
is this covered by some sort of test?
There was a problem hiding this comment.
Currently, code diff format is not covered by tests. I have to add tests for both project and file review. Will add them in followups.
There was a problem hiding this comment.
Can we add a comment explaining why we are doing this? It's hard to understand just by reading the code
There was a problem hiding this comment.
Added comment and corrected this for windows as well.
ashishrp-aws
changed the title
packages/amazonq/.changes/next-release/Bug Fix-0c35b577-da17-4132-a0b7-e0d630e73cb9.json
Outdated
Show resolved
Hide resolved
ctlai95
changed the title
…132-a0b7-e0d630e73cb9.json Co-authored-by: Justin M. Keyes <[email protected]>
## Problem - Code diff for file review format has changed in payload to improve LLM based code review accuracy and is dependent on git. ## Solution - We are currently send entire file in diff format and run git commands to extract it. This change will remove git dependency for LLM based code review issues.
3 participants
Problem
Solution
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.