Skip to content

fix(amazonq): Improved LLM code review for file review #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2024
Merged

fix(amazonq): Improved LLM code review for file review #6162

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98098f3
Fix for Code diff format for file review
ashishrp-aws Dec 5, 2024
f6b30d7
Added chaneglog
ashishrp-aws Dec 5, 2024
eac027c
Update packages/amazonq/.changes/next-release/Bug Fix-0c35b577-da17-4…
ashishrp-aws Dec 5, 2024
dc52c01
Fix for windows file review
ashishrp-aws Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-0c35b577-da17-4132-a0b7-e0d630e73cb9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Imrpoved LLm code review for file review."
}
8 changes: 2 additions & 6 deletions packages/core/src/codewhisperer/util/zipUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,8 @@ export class ZipUtil {
zip.addFile(zipEntryPath, Buffer.from(content, 'utf-8'))

if (scope === CodeWhispererConstants.CodeAnalysisScope.FILE_ON_DEMAND) {
await this.processCombinedGitDiff(
zip,
[workspaceFolder.uri.fsPath],
uri.fsPath,
CodeWhispererConstants.CodeAnalysisScope.FILE_ON_DEMAND
)
const gitDiffContent = `+++ b/${zipEntryPath}`
zip.addFile(ZipConstants.codeDiffFilePath, Buffer.from(gitDiffContent, 'utf-8'))
Copy link
Contributor

@justinmk3 justinmk3 Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this covered by some sort of test?

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, code diff format is not covered by tests. I have to add tests for both project and file review. Will add them in followups.

Copy link
Contributor

@ctlai95 ctlai95 Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment explaining why we are doing this? It's hard to understand just by reading the code

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment and corrected this for windows as well.

}
} else {
zip.addFile(uri.fsPath, Buffer.from(content, 'utf-8'))
Expand Down
Loading