Skip to content

fix(amazonq): revert disable event handler #6191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmk3 merged 1 commit into from
Dec 10, 2024
Merged

fix(amazonq): revert disable event handler #6191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-64bec56a-f152-4345-b036-0c5ddb0ce5a2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Code Review: Fixed a bug where applying a fix did not update the positions of other issues in the same file."
}
1 change: 0 additions & 1 deletion packages/core/src/codewhisperer/commands/basicCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,6 @@ export const applySecurityFix = Commands.declare(
new vscode.Range(document.lineAt(0).range.start, document.lineAt(document.lineCount - 1).range.end),
updatedContent
)
SecurityIssueProvider.instance.disableEventHandler()
const isApplied = await vscode.workspace.applyEdit(edit)
if (isApplied) {
void document.save().then((didSave) => {
Expand Down
9 changes: 0 additions & 9 deletions packages/core/src/codewhisperer/service/securityIssueProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export class SecurityIssueProvider {
}

private _issues: AggregatedCodeScanIssue[] = []
private _disableEventHandler: boolean = false
public get issues() {
return this._issues
}
Expand All @@ -21,19 +20,11 @@ export class SecurityIssueProvider {
this._issues = issues
}

public disableEventHandler() {
this._disableEventHandler = true
}

public handleDocumentChange(event: vscode.TextDocumentChangeEvent) {
// handleDocumentChange function may be triggered while testing by our own code generation.
if (!event.contentChanges || event.contentChanges.length === 0) {
return
}
if (this._disableEventHandler) {
this._disableEventHandler = false
return
}
const { changedRange, lineOffset } = event.contentChanges.reduce(
(acc, change) => ({
changedRange: acc.changedRange.union(change.range),
Expand Down
Loading